Offering to co-maintain the Poll module

Created on 29 March 2023, about 1 year ago
Updated 30 March 2023, about 1 year ago

Problem/Motivation

There are quite a lot of issues RTBC and there is no work being done currently to make a D10 compatible release.

I think this module could benefit from a new co-maintainer or even multiple. I would like to volunteer for this.

πŸ’¬ Support request
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium BramDriesen Belgium πŸ‡§πŸ‡ͺ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @BramDriesen
  • πŸ‡¨πŸ‡­Switzerland Berdir Switzerland

    Not against adding more maintainers, FWIW, the dev release is D10 compatible, confirmation of manual testing would be one way to help getting a release out.

    Many of the RTBC issues are either non-trivial feature requests/tasks that change stuff that need to be carefully evaluated or overlapping/duplicate coding standard issues that I often ignore.

  • πŸ‡§πŸ‡ͺBelgium BramDriesen Belgium πŸ‡§πŸ‡ͺ

    The "no work on D10" part was indeed not correct :-). In the end it's up to you if you decide to add more people or not.

    The last one (coding standards) etc I can totally understand, those have been a pain recently. I'm not referring to those issues either.

    My point is, the last tagged release dates back to December 2021, And D10 compatibility could have been worked on in a separate branch (2.0.x for example) to tag a dev and even an alpha release to show there is work being done behind the scenes. No offence to you or the other maintainers of course! But the module doesn't look maintained this way, on an alpha release or working branch it's "okay" to maybe break a thing here or there and fix it as we go. As for D10 a lot of things need to be re-tested anyway.

    Feel free to close it if you decide to not add new maintainers. No feelings hurt πŸ˜‰

  • Status changed to Fixed about 1 year ago
  • πŸ‡¨πŸ‡­Switzerland Berdir Switzerland

    Added you as a maintainer now. I'll do a release now as well unless something interrupts me.

    FWIW, I'm generally trying to avoid doing new major releases unless it's really necessary.

    > But the module doesn't look maintained this way
    > the other maintainers

    The module has always only been pretty minimally maintained. I've been the only active maintainer since 2015. We use it on a few projects since then, but I've more or less always only maintained it because nobody else did it. Those few projects are very large and have a lot of data in polls and in general though.

    As usual, I do ask that you give me a chance to review any non-trivial change and are careful with changes, especially the data structure.

  • πŸ‡§πŸ‡ͺBelgium BramDriesen Belgium πŸ‡§πŸ‡ͺ

    As usual, I do ask that you give me a chance to review any non-trivial change and are careful with changes, especially the data structure

    Yes of course! We need to be careful with that. I'll ping you on slack or something if something like that comes up.

    FWIW, I'm generally trying to avoid doing new major releases unless it's really necessary.

    Understandable, although it's a common practice to do D10 stuff on a new branch. But it should obviously be limited indeed, since major releases usually mean breaking changes. Which is something we all like to avoid ;-)

    Thanks @BramDriesen

  • πŸ‡¨πŸ‡­Switzerland Berdir Switzerland

    > Understandable, although it's a common practice to do D10 stuff on a new branch.

    I've done 50+ D10 compatibility releases and not a single one was a new major release only because of D10. There are cases where it's necessary, for example when Symfony API changes prevent supporting D9 and D10, but there are very few of those.

    Looking into test fixes before doing the release atm.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024