Blocked users get notifications when subscribed.

This is the patch implementing the proposed solution. It worked for me.

This is great, thanks a lot @s_castro for reporting and fixing this. I've just merged your patch.

This triggered some thoughts also related to blocked users:

• Should we delete subscriptions for users that get blocked or deleted?
• Should we delete notifications for users that get blocked or deleted? Or should we at least mark them as delivered?

Answering your questions with my opinion:

Should we delete subscriptions for users that get blocked or deleted?
The subscriptions should be deactivated when the user gets blocked (and reactivated again if the account is reactivated). When the user gets deleted the subscriptions should be deleted as well.

Should we delete notifications for users that get blocked or deleted? Or should we at least mark them as delivered?
I think marking them as delivered is okay as long as the subscriptions are blocked or removed and new notifications are not created.

Here is what's now implemented:

• Prevent new subscription notifications for blocked users (done in patch from #2)
• Prevent new notifications for deleted or blocked users
• If a user gets blocked, all undelivered notifications for that user get marked as delivered
• If a user gets deleted, all notifications for that user get deleted

Subscription settings for each user are stored in user data. Therefore, they remain intact while a user is blocked and will be still present when the user gets re-activated. When a user gets deleted, their user data also gets deleted; hence the subscription settings will be deleted too.

Please have a look and set to RTBC when all is ok.

Marking as fixed as I'm publishing a new version and need to include this. Should there be any issue still, please open a new issue then.

Automatically closed - issue fixed for 2 weeks with no activity.