When using the popover menu style, the javascript is attached as a behavior that checks for the direct add buttons in the context parameter. These buttons are found, but next, there is a check for the body element in the context, which returns null as the context is the #layout-builder element. Additionally, this second check seems unnecessary as we've already established that there are 'add block' buttons present.
As a result, the buttons will not work until you have refreshed the page or triggered another behavior which has the body as context.
Simplify the javascript and remove the unnecessary second check for the body element.
/**
* Attaches the JS test behavior to label links.
*/
Drupal.behaviors.lbDirectAdd = {
attach: function (context, settings) {
console.log(context);
var $directAddWidgets = $(once('lb_direct_add', '.layout-builder__add-block', context));
if ($directAddWidgets.length) {
var $body = $(once('lb_direct_add-click', 'body', context));
if ($body.length) {
$body.on('click', '.layout-builder__direct-add__toggle', directAddClickHandler);
}
var il = $directAddWidgets.length;
for (var i = 0; i < il; i++) {
DirectAddWidget.widgets.push(new DirectAddWidget($directAddWidgets[i], settings.lbDirectAdd));
}
}
}
};
Can be simplified to:
/**
* Attaches the JS test behavior to label links.
*/
Drupal.behaviors.lbDirectAdd = {
attach: function (context, settings) {
$(once('bind-click', '.layout-builder__add-block', context)).each(function() {
$(this).on('click', '.layout-builder__direct-add__toggle', directAddClickHandler);
DirectAddWidget.widgets.push(new DirectAddWidget(this, settings.lbDirectAdd));
});
}
};
Needs review
2.0
Code
Patch failed to apply.
Tried to recreate the patch.
I'm not 100% on this, but I think the reference to the the body element is about having a click event anywhere outside the popover/trigger cause the popover to close. Can you verify that the provided patch allows this behavior to continue?