Latest version unsets the administrator permission for JQuery Update

Created on 27 March 2023, over 1 year ago
Updated 9 August 2023, 11 months ago

Problem/Motivation

When updating to the latest version, the following permission gets unset:

Administer jQuery Update
Perform administration tasks for jQuery Update.

This means the admin no longer sees the JQuery Update menu item in the Development section of the menu, and they are also not able to see the jquery version's for themes to edit them.

Also, the default gets set to 1.12 for admin theme which breaks rules UI.

πŸ› Bug report
Status

Closed: works as designed

Version

4.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tonytheferg
  • Should the default version for Seven admin theme be 1.4 (Drupal Core)?

  • πŸ‡¬πŸ‡§United Kingdom mcdruid πŸ‡¬πŸ‡§πŸ‡ͺπŸ‡Ί

    Could we get any more steps to reproduce this? It also sounds like it may be two different issues.

    Upgrading to 7.x-4.x from which version? Did the permission itself change (i.e. not the same string) between 7.x-2.x and 4.x perhaps?

  • πŸ‡¬πŸ‡§United Kingdom mcdruid πŸ‡¬πŸ‡§πŸ‡ͺπŸ‡Ί

    Actually 7.x-2.7 didn't have a dedicated permission for jQuery Update, it just used 'administer site configuration':

    /**
     * Implements hook_menu().
     */
    function jquery_update_menu() {
      $items['admin/config/development/jquery_update'] = array(
        'title' => 'jQuery update',
        'description' => 'Configure settings related to the jQuery upgrade, the library path and compression.',
        'page callback' => 'drupal_get_form',
        'page arguments' => array('jquery_update_settings_form'),
        'access arguments' => array('administer site configuration'),
      );
    

    https://git.drupalcode.org/project/jquery_update/-/blob/7.x-2.7/jquery_u...

    The module's own permission was added in #2621436: Implement a permission for settings form β†’

  • Ah, you know, that may have been from me leap frogging a couple of versions.

    What version of jQuery is recommended for Seven admin theme in Drupal 7? 1.4 (Drupal Core)?

  • πŸ‡¬πŸ‡§United Kingdom mcdruid πŸ‡¬πŸ‡§πŸ‡ͺπŸ‡Ί

    I'm not sure about "recommended" version; perhaps it's reasonable to stay on core's default for the admin theme?

    If there's a problem with a popular contrib module and the version(s) jQuery Update ships with, we could look at patching it in jQuery Update with a JS shim? Or submit a patch for the contrib module in question.

    You mentioned an issue with Rules UI - does it seem like it'd be an easy fix?

  • Status changed to Closed: works as designed 11 months ago
  • πŸ‡¬πŸ‡§United Kingdom mcdruid πŸ‡¬πŸ‡§πŸ‡ͺπŸ‡Ί

    Please re-open if there's something we need to fix in the module, and thanks!

Production build 0.69.0 2024