- Issue created by @ultimike
- Assigned to akshaydalvi212
- 🇮🇳India akshaydalvi212
I will provide the patch file which will add the dependency of token_filter module.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:55am 27 March 2023 - 🇮🇳India akshaydalvi212
Patch file which addes the dependency of token_filter module as needed.
Kindly review. - Status changed to Needs work
about 1 year ago 6:01pm 27 March 2023 - 🇺🇸United States ultimike Florida, USA
Setting back to "needs work", as the issue description is asking whether or not this dependency is actually necessary.
There is no need for a patch until we determine that it is necessary.
-mike
- 🇺🇸United States ultimike Florida, USA
After digging into this a bit, I think @akshaydalvi212's patch is on the right track.
While Smart Trim doesn't have a hard dependency on Token Filter, if the latter is enabled, then the
testTokenNotCutOffTrimTypeCharacters()
andtestTokenNotCutOffTrimTypeWords()
tests confirm that Smart Trim handles things well.Therefore, I think we need to just add the following to the smart_trim.info.yml file in order to get tests to pass on drupal.org.
test_dependencies: - token_filter:token_filter
I don't think we want to add a dev dependency on Token Filter.
-mike
-
ultimike →
committed 13c7b753 on 2.0.x
Issue #3350497 by akshaydalvi212, ultimike: Add dependency on...
-
ultimike →
committed 13c7b753 on 2.0.x
- Status changed to Fixed
about 1 year ago 10:56am 29 March 2023 - 🇺🇸United States ultimike Florida, USA
Automatically closed - issue fixed for 2 weeks with no activity.