Doesn't work with custom vote sources

Created on 24 March 2023, over 1 year ago
Updated 13 January 2024, 10 months ago

Problem/Motivation

In Allow multiple votes from anonymous users on a shared IP address Needs review , we're working on adding different options for differentiating anonymous users. The problem is that currently, the rate widget hardcodes the current client IP as vote source.

Steps to reproduce

Add the patch from the above mentioned issue and choose an option other than 'One vote per IP'.

Proposed resolution

Use $vote->getSource() instead of hardcoding the client IP logic. This is a backwards compatible change, it will work with and without the patch from Allow multiple votes from anonymous users on a shared IP address Needs review .

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇧🇪Belgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024