D10 Compatibility

Created on 23 March 2023, over 1 year ago
Updated 2 June 2023, over 1 year ago

Just wondering if there are any plans to update this (possibly just the .info.yml file? 🀞) for Drupal 10. Thanks everyone!

✨ Feature request
Status

Needs review

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States attheshow

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @attheshow
  • πŸ‡ΊπŸ‡ΈUnited States joelsteidl

    Hi Mark!

    I think you are right...it looks to be as easy as updating the .info.yml file.

    Shockingly, all the modules in composer.json have D10 compatible versions.

    I do wonder if we should drop D8 support in the same commit.

    If you have time to test the patch, please do. I imagine this will get committed pretty soon.

  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States joelsteidl
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States attheshow

    Awesome. Thanks Joel. I hope you're doing well. I'll try to test this within the next week or two and let you know! 😊

  • πŸ‡«πŸ‡·France andrimont

    Hello all,

    I change the file stories.info.yml to accept D10,
    but installation gives an error during the process (that eventually went through) :
    The field_stories_curated_content entity reference field (entity_type: paragraph, bundle: stories_curated_content) no longer has any valid bundle it can reference. The field is not working correctly anymore and has to be adjusted.

    What should be done for that ?

  • πŸ‡ΊπŸ‡ΈUnited States attheshow

    Initial testing on the D10 compatibility has been good for us (using it on our existing D9 site). I noticed in the patch that the dependency on field_block module was removed so I tried uninstalling that module since it didn't appear to be used for anything else. Drush gave the error:

    block_field: The Block (plugin) field type is used in the following field: paragraph.field_stories_block

    It doesn't look like we have any uses of that field so I'm deleting the field and then uninstalling that module.

  • πŸ‡ΊπŸ‡ΈUnited States keiserjb

    The stories.media.info.yml should also change so the submodule works.

  • Status changed to Needs work over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States attheshow

    Good point @keiserjb. +1 to that. 😊

  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States attheshow

    Adding updated patch that updates the second .info.yml file.

  • πŸ‡ΊπŸ‡ΈUnited States joelsteidl

    Thanks @attheshow and @keiserjb!

    I tested this out on a pretty stock D10 site. It's a bit hard to test (with composer) since it modifies the info.yml file. This is how I went about it.

    I followed the steps outlined here for this module. https://gorannikolovski.com/blog/how-to-upgrade-drupal-9-to-10#how-to-in...

    In my composer.json, I specified that stories be installed from source so the Drupal.org packaging wouldn't be included.

        "preferred-install": {
            "drupal/stories": "source",
            "*": "auto"
        },

    I added the patch:

            "patches": {
                "drupal/stories": {
                    "#3350002 - D10 Compatibility": "https://www.drupal.org/files/issues/2023-06-02/3350002-d10-compatibility-10.patch"
                }
            },

    I'm going to go ahead and make an alpha 3.0.x release since one never existed.

  • πŸ‡ΊπŸ‡ΈUnited States joelsteidl

    Please checkout the 3.0 alpha release https://www.drupal.org/project/stories β†’

    This should be easier for folks to test without the complex composer workaround.

Production build 0.71.5 2024