Drush command should use interfaces.

Created on 23 March 2023, over 1 year ago

Updated 20 April 2023, over 1 year ago

Problem/Motivation

Currently the Drush command file is using classes instead of interfaces in its constructor:

public function __construct(FileSystem $file_system, ModuleHandler $module_handler) {

Using the FileSystem class especially can cause problems when other modules override the file system with their own classes, such as how the S3 File System module allows for.

Proposed resolution

Switching FileSystem and ModuleHandler references to interfaces retains the same functionality but makes it much more extensible. That's what the attached patch does.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States jacobbell84

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @jacobbell84
Comment over 1 year ago →
System Message

natemow → committed 8346f0a3 on 8.x-2.x authored by jacobbell84 →
Issue #3349983 by jacobbell84: Drush command should use interfaces
Status changed to Fixed over 1 year ago7:54pm 20 April 2023
Comment over 1 year ago →
🇺🇸United States natemow
Updated in the latest release, thanks for the patch!
Status changed to Fixed over 1 year ago7:55pm 20 April 2023
Comment over 1 year ago →
🇺🇸United States natemow

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024