- Issue created by @saganakat
- Status changed to Needs review
over 1 year ago 9:57am 24 March 2023 - 🇮🇳India nayana_mvr
@saganakat Please make sure to change the status of the ticket to 'Needs Review' if you are uploading a patch or raising MR. It will be easy for the community to review them quickly.
Verified the patch #2 on Drupal version 10.1.x and Gin Admin Theme version 8.x-3.x. The patch applied cleanly and it fixes the overlapping issue in horizontal tabs. I have attached the before and after screenshots for reference. Need RTBC+1 so moving to Needs Review.
- Issue was unassigned.
- 🇪🇸Spain saganakat
I apologize nayana_mvr → , I didn't know about the flow of the issue when proposing a patch.
Thanks for your comment.
- 🇮🇳India Santosh_Verma
#saganakant I reviewed your patch, in SCSS file you wrote a css in the style flow not as a SCSS, In the SCSS we follow the nesting rule. can you please change it
Thanks :)
- Status changed to Needs work
over 1 year ago 8:38am 26 March 2023 - Status changed to Needs review
over 1 year ago 6:55am 27 March 2023 - 🇮🇳India Nitin shrivastava
As per comment #9. I have updated the SCSS file using nesting.
Move to #needs review.. - 🇪🇸Spain saganakat
#santosh_verma Thanks! I'm re-uploading the patch with the suggested flow style.
- 🇮🇳India Santosh_Verma
patch #12 and #13 both are applied cleanly and working as expected on Drupal 10.1.x and Gin Theme
Thanks
@Nitin Shrivastava and @saganakant - Status changed to Needs work
over 1 year ago 10:08am 27 March 2023 - 🇨🇭Switzerland saschaeggi Zurich
Can we simplify the nesting used? Is it really necessary to use this type of nesting here? Also we should use Gin's CSS3 vars instead of a fixed rem value.
- Assigned to Santosh_Verma
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:33am 28 March 2023 - 🇮🇳India Santosh_Verma
@saschaeggi I have added a patch with reduced nesting and managing the space with CSS3 variable which is created in the theme
Befor
After
-
saschaeggi →
committed d83d43b1 on 8.x-3.x authored by
Santosh_Verma →
Issue #3349956 by saganakat, Santosh_Verma: Nested menus with horiztonal...
-
saschaeggi →
committed d83d43b1 on 8.x-3.x authored by
Santosh_Verma →
- 🇨🇭Switzerland saschaeggi Zurich
Great, thanks. I've done some linting and added a comment, but otherwise 👍
- Status changed to Fixed
over 1 year ago 6:44pm 24 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.