Indirect deprecations cause tests to fails

Created on 23 March 2023, about 2 years ago
Updated 9 May 2023, almost 2 years ago

Problem/Motivation

Unlike on DrupalCi the default GItlabCi template indicates a 'test' failure when libraries in the vendor directory emit a deprecation error.

Presumably we would not want these new 'failures' to occur during the conversion from DrupalCi, especially for vendor code we can not control.

Currently on DrupalCi all testing goes through \Drupal\Tests\Listeners\DrupalListenrer which filters out these indirect depreciation

See https://gitlab.com/drupalspoons/composer-plugin/-/issues/19 where DrupalSpoons has discussed this.

Steps to reproduce

Run GitlabCi with the template and code that causes an indirect deprecation (drupal/vault@11593086 should be sufficient if no other code exists)

Proposed resolution

Either add
SYMFONY_DEPRECATIONS_HELPER: weak environment variable as a default (I'm partial to this because it allows adding --coverage-filter web/modules/custom/ for code coverage to run in an expedient manner and generate a coverage file smaller than the GitLab 10mb limit without requiring modifications or replacement of a phpunit.xml file.)
OR -c web/core/phpunit.xml.dist to the phpunit command.

Remaining tasks

Discussion and patch.

πŸ› Bug report
Status

Fixed

Component

gitlab-ci

Created by

πŸ‡ΊπŸ‡ΈUnited States cmlara

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024