- Issue created by @sunlix
- @sunlix opened merge request.
- @sunlix opened merge request.
- π©πͺGermany sunlix Wesel
Hi,
I have added two possible ways to solve this issue.
I think MR19 would be the safest way to solve the URL creation on a entity base.It is inspired by the implementation at Drupal cores
EntityBase.php
https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/lib/Drupal/...
- Status changed to Needs review
about 2 years ago 4:10pm 22 March 2023 - π©πͺGermany sunlix Wesel
The failing Test's on D10.1 relates to the
$entity->label()
call in/core/modules/system/tests/modules/entity_test/src/EntityTestAccessControlHandler::checkAccess:73
.
At this point it isnull
.If I change the Test-Entity creation in the broken Test
ReorderChildrenFunctionalTest
like this, it works.$another_different_test_entity = EntityTest::create([ 'type' => 'someotherbundle', 'name' => 'No children here either', ]);
Is only the test incorrect or is here something more?
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Thanks for this - I've got it on my list to look at next week
-
larowlan β
committed 76a9cf04 on 3.x authored by
sunlix β
Issue #3349660 by sunlix: Missing MediaEntityHierarchyHandler
-
larowlan β
committed 76a9cf04 on 3.x authored by
sunlix β
- Status changed to Fixed
about 2 years ago 6:14am 30 March 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I agree 19 is better, thanks
Merged
I'll hold off creating a release in the hope we can get your other issue around setting value from the URL for the select widget beforehand too
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Automatically closed - issue fixed for 2 weeks with no activity.