- Issue created by @megachriz
- Status changed to Fixed
almost 2 years ago 10:08am 23 March 2023 - 🇳🇱Netherlands megachriz
@fgm
After 📌 Fix the issues reported by phpcs Fixed is done I plan to create a new release. I would like to release it as 8.x-1.0. Or is there any reason it should remain beta? I see that there is 📌 Rewrite XML RPC module to services and plugins Postponed , but if that one would ever get done I would think that would justify a new major version. - 🇫🇷France fgm Paris, France
That rewrite was a lot of work done by mostly by @ParisLiakos and reviewed then, but not updated since.
However, in the enthusiasm about the then-new plugins feature, IMO that issue completely misses the point of plugins: to provide pluggable services that could be configured at runtime. It therefore adds the cost of all that configurability and flexibility to XMLRPC which is by design something meant to remain frozen.
For that reason, I think I should just close it. What do you think ?
I think 🐛 system.methodSignature should return "undef" instead of error -32601 Fixed is more interesting, though: although it is tagged as a Feature Request, it should actually be considered a bug.
If you can fix it, I see no reason not to release 8.x-1.0.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 2:48pm 12 April 2023 - 🇳🇱Netherlands megachriz
I guess we could leave 📌 Rewrite XML RPC module to services and plugins Postponed open, so if someone does find it worth the effort to modernize this module, it will be visible to them that there has been worked on in the past. On the other hand, a smarter idea would probably be to let this module depend on an existing XML-RPC library instead.
I proposed a fix for 🐛 system.methodSignature should return "undef" instead of error -32601 Fixed now.
- 🇫🇷France fgm Paris, France
IIRC that is how it used to be, until it was completely rewritten (possibly by @chx ?) after a never-fixed security issue.
At this point, for all I know, this module might well be more secure than the PHP XML-RPC extension, so probably not such a good idea to port it back to the extension.
- 🇳🇱Netherlands megachriz
On packagist I came across this library for example: https://packagist.org/packages/phpxmlrpc/phpxmlrpc. It looks like that one is actively maintained.
I haven't checked its code and features, just a thought that if someone wants to rewrite this module it might a better idea to see if we can let this module depend on a library like that - instead of reinventing it as is done in 📌 Rewrite XML RPC module to services and plugins Postponed .