Drupal 10 add method calls to accessCheck() in getEntityForVoting()

Created on 22 March 2023, almost 2 years ago
Updated 3 June 2023, over 1 year ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine Vasyl Vasylkiv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Vasyl Vasylkiv
  • @vasyl-vasylkiv opened merge request.
  • Status changed to Postponed: needs info over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    Why FALSE? The default was TRUE, so this represents a change.

    See the change record at Access checking must be explicitly specified on content entity queries β†’

    Note, this module does not support Drupal 10 yet, so this is not a bug. It is a task that we need to accomplish before it is ready for D10.

    Also note that this module depends on Voting API, and the D10 version of Voting API was just released TODAY (by me ...). So it is only now that we can finish off making Voting API Widgets compatible with D10.

  • Status changed to Needs work over 1 year ago
  • πŸ‡ΊπŸ‡¦Ukraine voleger Ukraine, Rivne

    Trying to install the module using the Drupal lenient plugin, it looks like this is one of the deprecation notices appearing wherever the voting plugin renders on the page.
    After reviewing the proposed changes, it makes sense to change to fit the default behavior to true.
    And yeah, it would be great if you open 2.0.x branch with ^9.5 || ^10 core compatibility declaration to not break compatibility with Drupal 8 in 1.x branch.

  • Open on Drupal.org β†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • Open on Drupal.org β†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • Status changed to Fixed over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    Merged.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024