Big Pipe, logged-in users and 4xx pages

Created on 20 March 2023, almost 2 years ago

Problem/Motivation

When the language switcher block is rendered for 404 pages an interesting thing happens. Without big_pipe enabled we get links to system/404 - so we get links to pages which are a 200 response but with 404 content. With big_pipe enabled and a logged-in user we get links to the front page. This is because only the sub-request has the correct routing information.

Steps to reproduce

Once 🐛 [regression] Language switcher block throws exception when no route is matched Fixed run \Drupal\Tests\language\Functional\LanguageSwitchingTest::testLanguageBlock()

Proposed resolution

Not sure. But the fact that system/401, system/403, system/404 and system/4xx are all valid URLs on a Drupal site is very odd. If you hit them directly they all return a 200 response.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

10.1 ✨

Component

Routing →

Last updated 3 days ago

Maintained by
🇺🇸United States @tim.plunkett

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @alexpott
Status changed to Needs review almost 2 years ago11:18am 21 March 2023
Comment almost 2 years ago →
🇬🇧United Kingdom catch
Here's a variation of #22 which only swaps the routing information for the main request if it doesn't already have some.

For me this fixes Drupal\Tests\system\Functional\System\AccessDeniedTest
Comment almost 2 years ago →
System Message
The last submitted patch, 3: 3349201.patch, failed testing. View results →
Status changed to Needs work 2 months ago11:32am 18 October 2024
Comment 2 months ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
This appears to be caused by 🐛 Requests are pushed onto the request stack twice, popped once Needs work and fixing that fixes this!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024