Deprecated use of strstr

Actually i can't really reproduce this. I tried to fix this warning with 202b36597. However can you try adding a null coalescing operator instead?

if (strstr($route_name ?? '', 'entity.api_key')) {
    return FALSE;
}

@markaspot, I can't reproduce this in all environments, it's happening on php 8.1.15.

That null coalescing operator will have the same issue. The deprecation is that strstr doesn't support an empty string in the first argument, so whether it's a ternary or null coalescing that first argument being empty will throw a deprecation warning.

You either have to fix it the way I did or wrap the whole clause in an if else and I think since it returns checking to see if it's null is cleaner than a nested if else.

Thank you, I added a new release.

This change breaks my authentication. Sorry for making this change without thorough testing. I will reopen this issue with an updated status and create a new release that rolls back the change. I am sorry for any inconvenience this may have caused.

Would you be willing to use the 3.0.2 release and possibly assist with testing it? It seems like this module could use additional support.

Could you please test the latest dev-commit again? I was able to reproduce the deprecation warning you mentioned without the null coalescing operator, but adding it fixed the issue for me using PHP 8.1.15. If you could confirm that the solution works for you, I would be happy to create a new release as soon as possible.

I'm happy to test, after removing my patch and switching to dev I no longer get a deprecation notice!

Sorry for that issue with authentication, I had thought my patch was functionally similar.

Markin this fixed as it was merged into 3.0.x Any further steps needed @markaspot & @nicxvan?

Not that I am aware of thanks!

Automatically closed - issue fixed for 2 weeks with no activity.