Offering to maintain eca_form within its own contrib project

Created on 20 March 2023, over 1 year ago
Updated 13 April 2023, over 1 year ago

Problem/Motivation

There seems to be some concerns regarding components I have contributed to this project. Examples:

Therefore, I'm offering to maintain eca_form as its own contrib project, moving it out of the main ECA project.

I'm also willing to move further modules out to their own, for example eca_endpoint and eca_render.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🌱 Plan
Status

Closed: works as designed

Version

1.2

Component

Miscellaneous

Created by

🇩🇪Germany mxh Offenburg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mxh
  • 🇩🇪Germany mxh Offenburg

    This could be a task when going for 2.0.x maybe?

  • 🇩🇪Germany jurgenhaas Gottmadingen

    This feels not good, that I have again to explain, that no bad intention whatsoever is in any of my comments. But since you challenge me again in a way that I feel very uncomfortable with, I do respond here.

    https://www.drupal.org/project/eca/issues/3348940#comment-14974194 💬 Conditional fields functionality Fixed From our own experience ... don't use it ourselves. Compared to the UI of the conditional_fields module, this is so much more tailored towards the task to set conditions and states for fields in forms ...

    With that comment, there are NONE "concerns regarding components I have contributed to this project". I'm speaking about my own experience about a specific module which does a good job and where I personally don't see the point in trying to compete with that module. There is NOTHING about your contributions - and you know how much I respect your input to ECA. So please, don't make up such arguments.

    https://www.drupal.org/project/eca/issues/3346508#comment-14961143 🐛 eca_form: Form field actions are not working well for multi-property fields Fixed I remember some other issues where we touched that trait. It could well be kind of a time-bomb, so I'd be OK to go for a "real" fix for 2.0

    Well, I do remember discussions about that trait and I wanted to open the door to rework this trait if the argument about breaking changes were the only reason not to do so, as was argued before. It was made clear after my statement, that I'm the only one with that perspective and I never mentioned it afterwards, accepting the counter-argument.

    I don't see either how that would express any concern regarding your contributions.

    I'm offering to maintain eca_form as its own contrib project, moving it out of the main ECA project.

    I'm not in favour of this approach. ECA has a strong proposal as a module to work out of the box with a huge list of features but without extra dependencies other than Drupal core. This is well received by ECA users, and therefore we should keep everything in ECA's main module that only depends on core.

    All other extensions, that also depend on other components, should go into their own modules, just like we've done so far pretty successfully.

  • 🇲🇾Malaysia rodmarasi

    guys, i really hope both of you can do google meet or zoom to solve this problem. sometimes text communication not the best way to discuss certain issues. think win win.

  • Status changed to Closed: works as designed over 1 year ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    Closing this, but please don't hesitate to re-open if we needed to address this further.

Production build 0.71.5 2024