SocialCommentUploadConfigOverride gets config unnecessary repeatedly

Created on 15 March 2023, over 1 year ago
Updated 25 April 2023, about 1 year ago

Problem/Motivation

We're doing unnecessary config get calls in SocialCommentUploadConfigOverride. These should be inside of the if statement where the rest of logic is executed.

Steps to reproduce

Set a breakpoint in SocialCommentUploadConfigOverride at around the lines where it is doing the config get calls. This is happening pretty often.

Proposed resolution

There is already an if statement checking if the logic needs to be further executed. We can move the expensive config get calls inside of these two separate if statements to allow the config get calls to be executed only when it is actually applicable.

Remaining tasks

N/a

User interface changes

N/a

API changes

N/a

Data model changes

N/a

πŸ› Bug report
Status

Fixed

Version

11.8

Component

Code (back-end)

Created by

πŸ‡³πŸ‡±Netherlands bramtenhove

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024