The preview is showing redundant controls which should be shown in a new window instead

Created on 15 March 2023, almost 2 years ago
Updated 7 April 2023, over 1 year ago

Problem/Motivation

I've installed the latest dev version on a fresh local install with ddev running 10.1.-x with php 8.2.0. i've tested on Macos 12.6.1 and Safari 16.1 as well as the latest edge, the results are identical.
when i am opening a preview i see the redundant screen components.

the back to content editing button is identical function wise with the close button in the upper right corner while the view mode select boxes are identical function wise. they only differ in style and slightly in size and position on the y axis

Steps to reproduce

  1. Start with a fresh install
  2. Turn on same_page_preview
  3. Create a new piece of content
  4. Open preview
  5. Observe the duplicative view mode drop downs.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Closed: works as designed

Version

1.0

Component

User interface

Created by

๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Comments & Activities

  • Issue created by @rkoller
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul

    I'll be looking at this one this weekend. My rush to get the dev release out may have excluded some work we have to make sure this doesn't happen.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul

    @rkoller I attempted to author some testing steps that seem to describe what you did to create this situation. If they're wrong, can you please edit them?

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    Good point. thanks. i forgot to make the steps more explicit since i did more or less nothing aside requiring and installing the module. but made a few adjustments to the steps you've outlined. (and by the way the duplicated view mode drop down is still 100% reproducible on my end - happened on another page i quickly installed the module on to recheck the steps. version used is from 14 Mar 2023 at 22:10 UTC)

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul

    Here's the testing steps I've done:

    1. Created a new site from scratch
    2. Use composer to get the dev version of same_page_preview
    3. Install site using demo_umami installation profile.
    4. Edit an existing piece of content.

    Here's what I see:

    I can't reproduce the bug. @rkoller can you?

  • Status changed to Postponed: needs info almost 2 years ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States brianperry

    I actually posted this on https://www.drupal.org/project/same_page_preview/issues/3348315#comment-... ๐Ÿ› Installation on already existing sites broken with no real preview shown Fixed but looking at this again, this actually feels like the one that is more like a cache-adjacent issue. We're doing some altering to remove the controls from the preview embedded in the iframe. This feels like the alter hasn't registered yet somehow.

    I'm still not able to duplicate this locally though.

  • Status changed to Closed: works as designed over 1 year ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    I suppose I've figured out the root cause. the redundant controls were due to the fact that i've used drupal 10.1.x for testing purposes instead of 10.0.x. Realized that in a conversation with @cosmicdreams today when i was trying to get a drupalpod instance running. there i've learned that 10.1.x uses a different render element and something has to change in same page preview for that. installed now three different instances (one drupalpod and two local one) and it turns out in none of them the redundant controls have showed up. closing this issue as works as designed.

Production build 0.71.5 2024