- Issue created by @solideogloria
- Assigned to elber
- @elber opened merge request.
- Status changed to Needs review
about 2 years ago 6:07pm 15 March 2023 - Status changed to Needs work
about 2 years ago 9:29pm 15 March 2023 - 🇦🇺Australia acbramley
Comments added to the MR, we also need a test because currently it is broken.
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 10:55am 16 March 2023 - Status changed to Needs work
about 2 years ago 1:47pm 16 March 2023 I would suggest using a different form ID than
big_menu_form_id_settings
. It seems wrong to put "form_id" in the ID. How aboutbigmenu_settings
(the module name doesn't have a space in it).Similarly, in the routing file, it should be
bigmenu.settings
, notbig_menu.settings
(the module name doesn't have a space in it).Then, we should add
configure: bigmenu.settings
to the info file.- Status changed to Needs review
about 2 years ago 2:00pm 16 March 2023 The code looks good to me, but I can't get the patch to apply when I tried using Composer. I don't know why.
Also we should fix the Composer errors that show for the tests.
- Status changed to Needs work
about 2 years ago 9:33pm 16 March 2023 - Status changed to Needs review
about 2 years ago 3:28pm 29 March 2023 - 🇧🇷Brazil elber Brazil
Hi I install the module using composer after that ran the issue fork's commands and checkout to respective branch.
I was able to revised the changes using composer to install the module.
- Status changed to Needs work
about 2 years ago 6:18pm 29 March 2023 per #11, this has to stay Needs Work until tests are added.
- Assigned to elber
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 2:10pm 3 April 2023 - 🇧🇷Brazil elber Brazil
Hi I added a test to this new feature please revise
Testing Drupal\Tests\bigmenu\Functional\BigMenuSettingsFormTest . 1 / 1 (100%) Time: 00:13.657, Memory: 10.00 MB OK (1 test, 10 assertions)
Test is passing
-
acbramley →
committed 1d3475fd on 2.x authored by
elber →
Issue #3348166 by elber, acbramley, solideogloria: Add a config form
-
acbramley →
committed 1d3475fd on 2.x authored by
elber →
- Status changed to Fixed
almost 2 years ago 12:29am 18 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.