- Issue created by @wim leers
- @wim-leers opened merge request.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 11:55am 15 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Got this started, including some examples. Somebody else can finish this 😊
- First commit to issue fork.
- @ranjit1032002 opened merge request.
- Status changed to Needs review
over 1 year ago 2:05pm 15 March 2023 - 🇮🇳India Ranjit1032002
Created MR!787 for the issue mentioned, please review.
Thank You. - Status changed to Needs work
over 1 year ago 2:09pm 15 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks for your contribution, @Ranjit1032002!
There are many other examples of this pattern:
$inspector = $this->container->get('package_manager.composer_inspector');
et cetera.
We need to update all of those too.
- First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
Closing !787 in favor of !786, which is further along. (Don't worry, @Ranjit1032002, you'll still be credited when this is committed.)
- Assigned to kunal.sachdev
- 🇮🇳India kunal.sachdev
If I am not wrong, we'll need to define aliases of services if we want to do
$this->container->get(ClassName::class)
. - 🇺🇸United States phenaproxima Massachusetts
That is correct, until we drop backwards compatibility with the old service IDs. There are already examples in Package Manager's services.yml.
- 🇮🇳India kunal.sachdev
With @Wim Leers, tried to resolve the failure
The "PhpTuf\ComposerStager\Domain\Core\Stager\Stager" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.
, turns out we can't define alias in this case. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:19am 24 March 2023 - 🇺🇸United States phenaproxima Massachusetts
Tightly scoped, very clean, passing tests, looking great. It will be my pleasure to commit this.
- Status changed to RTBC
over 1 year ago 1:33pm 24 March 2023 -
phenaproxima →
committed 0d54cf27 on 3.0.x authored by
Wim Leers →
Issue #3348129 by kunal.sachdev, phenaproxima, Wim Leers, Ranjit1032002...
-
phenaproxima →
committed 0d54cf27 on 3.0.x authored by
Wim Leers →
- Status changed to Fixed
over 1 year ago 2:02pm 24 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.