- Issue created by @mpotter
- Assigned to sakthi_dev
- Issue was unassigned.
- 🇮🇳India sakthi_dev
Not reproducible, please provide the screenshots and the steps to reproduce from installation.
- Status changed to Closed: cannot reproduce
over 1 year ago 5:36pm 17 March 2023 - 🇺🇸United States mpotter
Hmm, just tried it in a fresh site and also cannot reproduce. Must be something specific to this other project theme that is bleeding into layout builder and gin. Although not sure how it would prevent the gin variables from being set correctly.
In any case, closing due to not reproducing.
- Status changed to Active
over 1 year ago 5:46pm 17 March 2023 - 🇺🇸United States mpotter
Oh, nope, doh, I was testing CKEditor4 and not CKEditor5. I can still reproduce this (in D9.5.x)
* Install and enable latest versions of `gin` and `gin_lb`
* Set Admin theme to Gin, and enable "Use Admin theme for editing content"
* In Gin Settings, set Appearance to Dark
* Enable CKEditor5
* Go into the Text formats and Editors config, select Basic HTML, set the editor to CKEditor5
* Create a content type that uses Layout Builder
* Create a page of that content type and go to Layout tab
* Add a Basic Block to the page. The sidebar config flyout will be in dark mode, but CKEditor5 will have a white background. - Status changed to Needs review
over 1 year ago 9:55am 22 March 2023 - 🇮🇳India chaitanyadessai
Adding patch for ckeditor in gin dark mode ,Please review.
- 🇺🇸United States mpotter
I think there are some additional colors that need tweaking for dark mode. In addition to the toolbar background, the toolbar text color needs to be set, along with the background of the select drop-down fields (like heading)
- 🇮🇳India chaitanyadessai
@mpotter Adding patch with changes , please review
- Status changed to Needs work
about 1 year ago 9:32am 14 April 2023 - 🇵🇱Poland bronisMateusz
Not working with rc3. Probably in path need change selector from `.ui-dialog .ck` to `.ck`