- Issue created by @renatog
- @renatog opened merge request.
- Status changed to Needs review
over 1 year ago 8:17pm 12 March 2023 - 🇧🇷Brazil renatog Campinas
Fixed. Merge request with that is available at: https://git.drupalcode.org/project/openchurch_theme/-/merge_requests/1
- 🇮🇳India nayana_mvr
Verified the MR!1 on Drupal version 9.5.x and OpenChurch Theme version 3.0.x. The patch applied cleanly and now an error message is displayed when an invalid color code is given n the 'Link Color' field. I have added the before and after screen recordings for reference.
Just one more concern:- The text font color of that field is always white. Is it expected to be like that? Because if we put some invalid color in that field and try save the configuration, then the background color of that field will be white which makes it difficult to read the text given in that field (Please refer screen recording for more clarity.) - 🇧🇷Brazil renatog Campinas
The text font color of that field is always white. Is it expected to be like that?
makes it difficult to readI also see that, but I think is a different issue. So I reported at 🐛 Font color in white is card to read Fixed
-
drupalninja99 →
committed 159b52e4 on 3.0.x authored by
RenatoG →
Issue #3347505: Validate if the element has valid color before saving
-
drupalninja99 →
committed 159b52e4 on 3.0.x authored by
RenatoG →
- Status changed to Fixed
over 1 year ago 9:53pm 25 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.