- Issue created by @MegaKeegMan
- πΊπΈUnited States wolcen
To be clear: we were unsure if the new tests added by that commit are the "cause" of the issue - we don't know if module is perhaps loading the private key improperly, or if phpseclib is doing a new test when it really didn't need to (or should have just exited).
Did not see any complaints on the phpseclib side so far.
- π§πͺBelgium swentel
It is indeed due to the phpseclib library which kind of added a BC break imo on a patch release.
The annoying this is that I probably can't lock it in my composer.json since the dependency is in the ActivityPub PHP library, unless that works, let's double check.
- Status changed to Needs review
almost 2 years ago 12:06pm 11 March 2023 - π§πͺBelgium swentel
Note, confirmed locally, tests still pass on 3.0.18, fails on 3.0.19
- π§πͺBelgium swentel
Oh and the tests pass, that's cool. Check the console output, and indeed, locking it in our composer fixes it nicely.
- Locking phpseclib/phpseclib (3.0.18)
will commit now.
-
swentel β
committed 010ca9de on 1.0.x
Issue #3347350 by swentel, MegaKeegMan, wolcen: Error creating the...
-
swentel β
committed 010ca9de on 1.0.x
- π§πͺBelgium swentel
committed, thanks for reporting this, and the link to the commit definitely helped this track easily!
- Status changed to Fixed
almost 2 years ago 12:16pm 11 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.