getDerivativeDefinitions() does not return an array for plugin "advanced_help.local_tasks".

Thank you for the patch!

It look straightforward, but I still need some more eyeballs on this. Unassigning to open up for others to review it.

Hi gturnbull,

I applied patch #2 to the "Advanced Help" module against Version 8.x-1.x-dev, and noticed that the issue was not resolved, and when I clear cache in my terminal I can also see the error/warning.

Please see the screenshots attached.

For your review.
Thank you.

Hi clarkssquared,
Thank you for taking the time to test my patch.

After applying the patch, the advanced_help module will have a new project dependency, the Help module provided by Drupal core.

If you then install the help module provided by Drupal core, the error/warning should no longer appear in the Drupal event log when you load pages on your site.

Hope this helps.

Thank you,
Gordon

Hi clarkssquared,
Here are some steps to help with testing:

1. Ensure the Help module provided by Drupal core is uninstalled.
2. Ensure the Advanced Help module is installed.
3. Apply the patch from comment #2.
4. Uninstall the Advanced Help module.
5. Re-install the Advanced Help module. This time, the Help module provided by Drupal core will be listed as a project dependency, so you will be required to install the Help module while installing the Advanced Help module.
6. Load any page on your site.
7. Check the Drupal event log. You should no longer see the error/warning when pages are loaded.

Hi gturnbull,

Thank you for providing the steps which are indeed helpful, I followed through with your steps as I retested the issue and I load a page in my site and clear cached and confirmed that the issue was resolved.

Please see the screenshots attached for your reference

For your review.
Thank you.

Hi clarkssquared,
Thank you for testing my patch! Your time and effort is greatly appreciated.

Best regards,
Gordon

This is fixed in the latest snapshot of the 8.x-1.x-dev branch.

Automatically closed - issue fixed for 2 weeks with no activity.