Remove TODOs and add logging

Created on 10 March 2023, over 1 year ago
Updated 21 October 2023, 8 months ago

Problem/Motivation

Remove TODOs and add logging in class OneSignal.php.

πŸ“Œ Task
Status

Fixed

Version

2.2

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany danielspeicher Steisslingen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @danielspeicher
  • @danielspeicher opened merge request.
  • Status changed to Needs review over 1 year ago
  • πŸ‡©πŸ‡ͺGermany danielspeicher Steisslingen
  • Status changed to Needs work over 1 year ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    I've had a look and while this is looking good, I wonder about 2 things:

    • We may have to add a string to the error message to tell in which context this error occurred, e.g. $this->logger->error('OneSignal failed to POST credentials: ' . $e->getMessage());. Without that, it may be difficult to know where an error appeared.
    • Do we also require arguments at that point? It might be important to see the variable values as part of the error message too; otherwise we may not be able to tell, why an error occurred.

    The stack trace is most likely not necessary, I guess. From the other information above it should be possible to tell how we came to that location.

  • Status changed to Fixed 8 months ago
  • πŸ‡©πŸ‡ͺGermany danielspeicher Steisslingen
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024