Remove FixtureManipulatorTest's reliance on installed.json and installed.php

Created on 10 March 2023, almost 2 years ago
Updated 30 March 2023, over 1 year ago

Problem/Motivation

Discovered in #3316368-44: Remove our runtime dependency on composer/composer: remove ComposerUtility โ†’ .

See:

  • getData()
  • assertOriginalFixturePackagesUnchanged()
  • testAddPackage()
  • testModifyPackageConfig()
  • โ€ฆ

These rely on parsing composer/vendor/installed.json, which is not public Composer API, but something internal.

Proposed resolution

That should be able to use ComposerInspector now โ€” so we can stop relying on composer/vendor/installed.json ๐Ÿ˜Š

Or โ€ฆ in quite a few of these cases, it could be argued that the test coverage was only necessary when we were still using ComposerUtility, which ๐Ÿ“Œ Remove our runtime dependency on composer/composer: remove ComposerUtility Fixed removedโ€ฆ โš ๏ธ

โ‡’ this can only be worked on by @phenaproxima or @tedbow

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

๐Ÿ“Œ Task
Status

Fixed

Version

3.0

Component

Code

Created by

๐Ÿ‡ง๐Ÿ‡ชBelgium wim leers Ghent ๐Ÿ‡ง๐Ÿ‡ช๐Ÿ‡ช๐Ÿ‡บ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024