- Issue created by @s_leu
- @s_leu opened merge request.
- Status changed to Needs review
over 1 year ago 4:06am 10 March 2023 - Status changed to Fixed
over 1 year ago 3:58pm 24 March 2023 - Status changed to Needs work
over 1 year ago 3:56am 30 March 2023 Re-opening this because there's yet a problem with excluding certain bundles or entire entity types from workflows via
hook_entity_workflow_type_alter()
and manipulating$configuration['entity_types']
to remove bundles or entire entity types from a workflow.The problem seems to be that the
RouteEnhancer
is not really checking the possibly altered workflow config. InRouteEnhancer::enhance()
the only check that happens is if a bundle/entity type is part of a workflow by callingEntityWorkflowInfo::getWorkflowsInfoForEntityTypeAndBundle()
orEntityWorkflowInfo::getWorkflowsInfoForEntityType($entity_type_id)
. Thus, this code gets all bundles/entity types regardless of whether they are βaltered outβ viahook_entity_workflow_type_alter()
or not.To solve this we need to check the actual workflow configuration that is possibly altered. I'm not sure whether this should happen inside the route enhancer or not, but I'm adding it there for now. I can still move it if it makes more sense to have this inside
EntityWorkflowInfo
but as I'm not completely familiar with this module it could have unwanted side effects which I'm unaware of to add it there.- @s_leu opened merge request.
- Status changed to Needs review
over 1 year ago 4:21am 30 March 2023 -
amateescu β
committed 6ba3cda5 on 2.x authored by
s_leu β
Issue #3347119: Consider possibly opted out entity types and/or bundles...
-
amateescu β
committed 6ba3cda5 on 2.x authored by
s_leu β
- Status changed to Fixed
over 1 year ago 8:54pm 17 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.