increase max character limit to 50000

Hi @Shiraz,

Since, you provided a patch, I am setting the issue status as 'Needs Review'.

Also, I am assigning it to myself for reviewing your patch.

Will provide the feedback soon.

Thanks

Hi @Shiraz,

Your patch failed to apply.

Moving the issue status to Needs Work.

Although, the work you did is correct, but probably because of some pushes to the repository, the code changed a bit.

If, I have to explain this further:
Your patch contains-

-  protected $maxCharacters = 5000;
+  protected $maxCharacters = 50000;
 
   <strong>/**
    * Guzzle HTTP client.</strong>

Where as, in recent code,

-  protected $maxCharacters = 5000;
+  protected $maxCharacters = 50000;
 
  <strong> /**
    * {@inheritdoc}</strong>

It is like this.

Your patch is failing here,

Checking patch src/Plugin/tmgmt/Translator/MicrosoftTranslator.php...
error: while searching for:
   *
   * @see https://docs.microsoft.com/en-us/azure/cognitive-services/translator/reference/v3-0-translate?tabs=curl#request-body
   */
  protected $maxCharacters = 5000;

  /**
   * Guzzle HTTP client.

error: patch failed: src/Plugin/tmgmt/Translator/MicrosoftTranslator.php:43
error: src/Plugin/tmgmt/Translator/MicrosoftTranslator.php: patch does not apply

Because there is no

/**
   * Guzzle HTTP client.

After the "protected $maxCharacters = 5000;" in current code.

I am keeping this assigned to myself, and will provide a patch.

Thanks

Oh thanks so much. Yes, I did this on the stable release not the dev release, as we were hoping we could stick on stable, but if it's changed to the point where it needs to be on dev release, we'll switch. Thanks for looking at this!

Here is the patch.

Please review.

Thanks

Thank you! I can confirm that patch applies correctly on the dev release.

Not sure if you want to wait for others or not to commit.

If, you have reviewed this, we could probably move it to RTBC and I can commit.

What is your opinion on this?

My opinion is it's a very simple change code-wise so there's no concern there. The bigger question is does it work, and in my tests, it did. Ideally someone else would test with a translation greater than 5000 characters to confirm, but it did work for me, and as far I personally am concerned, I'd like to see it get committed, but there's no rush. I'm not sure how actively used this module is -- in fact I was surprised to have someone reply so quickly (thank you).

So, IMHO we must wait for someone else to test it thoroughly and if everything goes well, we will have this committed.

Thanks for the quick responses. I highly appreciate it.

Have a great day ahead.

Agreed. And, my day has just ended! Warm wishes from Canada!

Looks great.

Thank you!

Automatically closed - issue fixed for 2 weeks with no activity.