- Issue created by @enyug
- 🇦🇺Australia dpi Perth, Australia
Why can't the Diff make this change?
This page has traditionally been called Revisions, when viewed with a proper breadcrumb, you should already see the entity title. There shouldnt be a need for duplication. Otherwise you're going to have breadcrumb + title blocks look like:
Home > Content > My FooBar Node
Revisions for My FooBar NodeOr on revision view pages:
Home > Content > My FooBar Node > Revisions for My FooBar Node
Revision of My Foobar Node from Tue, 10/30/2023 - 15:19 - 🇦🇺Australia enyug
public function revisionOverview(NodeInterface $node) { $langcode = $node ->language() ->getId(); $langname = $node ->language() ->getName(); $languages = $node ->getTranslationLanguages(); $has_translations = count($languages) > 1; $node_storage = $this ->entityTypeManager() ->getStorage('node'); $build['#title'] = $has_translations ? $this ->t('@langname revisions for %title', [ '@langname' => $langname, '%title' => $node ->label(), ]) : $this ->t('Revisions for %title', [ '%title' => $node ->label(), ]);
I assume it should be consistence with what implemented in NodeController
- 🇦🇺Australia dpi Perth, Australia
Many parts of the node implementation were intentionally not brought over. The intention was not to fully replicate it out of the gate.
We can re-evaluate whether this should be brought over in this issue.
Based on #2 I'd prefer to not see duplicate information in breadcrumb + title.
consistence with what implemented in NodeController
Since as you mentioned this is also in Node, the issue summary should be updated to reflect the desire to copy whats in Node, rather than a contrib (diff).