Can't save a template if I used long label

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'label' at row 1: INSERT INTO "section_library_template" ("uuid", "langcode", "user_id", "label", "type", "entity_id", "entity_type", "image__target_id", "image__display", "image__description", "created", "changed") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10, :db_insert_placeholder_11); Array ( [:db_insert_placeholder_0] => 50d6c8cf-860e-4b55-b282-2b799737f554 [:db_insert_placeholder_1] => en [:db_insert_placeholder_2] => 1 [:db_insert_placeholder_3] => Lorem ipsum dolor sit amet consectetur adipiscing elitrwt [:db_insert_placeholder_4] => template [:db_insert_placeholder_5] => 1387 [:db_insert_placeholder_6] => node [:db_insert_placeholder_7] => [:db_insert_placeholder_8] => [:db_insert_placeholder_9] => [:db_insert_placeholder_10] => 1678180683 [:db_insert_placeholder_11] => 1678180683 )

Comments & Activities

Issue created by @Odai Atieh
Status changed to Needs review about 2 years ago2:27pm 7 March 2023
Comment about 2 years ago →
🇯🇴Jordan Odai Atieh Amman
First commit to issue fork.
Merge request !17Issue #3346504: Can't save a template if I used long label → (Merged) created by matthijs
Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
Waiting for branch to pass
Comment over 1 year ago →
🇧🇪Belgium matthijs
The PR changes the maxlength of the label textfield to 50 instead of altering the field definition like the patch does.
I've hidden the patch because it deletes all existing entities during the update hook, which looks dangerous to me.
Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
Waiting for branch to pass
Comment over 1 year ago →
🇧🇪Belgium weseze
It's probably much easier to just change the allowed length on the label fields, rather then changing the schema and existing field.
See attached patch.
Comment over 1 year ago →
🇧🇪Belgium matthijs
@weseze: maybe update the merge request as well with your change to AddSectionToLibraryForm.
Comment 3 months ago →
🇺🇸United States jastraat
This is still an issue; I like the idea of simply updating the max length on the form fields.
Comment 3 months ago →
🇺🇸United States jastraat
Tested setting the max length of 50 to match the entity definition on the two add form label fields. This prevents users from entering a label that is too long. Updated the merge request to reflect updating both add forms.
Comment 3 months ago →
🇺🇸United States jastraat
Pipeline finished with Skipped
3 months ago
#391005
Comment 3 months ago →
System Message

jastraat → committed d3d91fa1 on 1.2.x authored by matthijs →
Issue #3346504 by matthijs, jastraat, odai atieh, weseze: Add forms...
Comment 3 months ago →
🇺🇸United States jastraat
Comment 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Can't save a template if I used long label

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!17Can't save a template if I used long label
Merged

Comments & Activities

Can't save a template if I used long label

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!17Can't save a template if I used long labelMerged

Comments & Activities

!17Can't save a template if I used long label
Merged