skip_on_substr plugin doesn't support logging messages to migration logs

Created on 3 March 2023, almost 2 years ago

Updated 2 March 2024, 10 months ago

Problem/Motivation

When a row or process is skipped after using the `skip_on_substr` plugin, there is currently no capability to log anything to the migration logs;

$ drush migrate:import migration_abc
[notice] Processed 463 items (461 created, 0 updated, 0 failed, 2 ignored) - done with migration_abc
$ drush migrate:message migration_abc
[notice] No messages for this migration

This can be problematic as it's not always clear which entry was skipped, or why.

Proposed resolution

Extend the `skip_on_substr` plugin to support a `message` config item and logging the value to the migration logs

✨ Feature request

Status

Needs review

Version

2.0

Component

Code

Created by

🇦🇺Australia timfletcher

Live updates comments and jobs are added and updated live.

logs

Comments & Activities

Issue created by @timfletcher
@timfletcher opened merge request.
Status changed to Needs review 10 months ago1:00am 2 March 2024
Comment 10 months ago →
🇺🇸United States swirt Florida
Hi @timfletcher Sorry for missing this and thank you for the contribution.

I am changing the status to "Needs review" so we can take a look and maybe get the status moved to Reviewed and tested by the community. As variations in migrations are challenging to test, it would be great if you could provide a sample of your config and evidence of the patch working and messages being logged.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024