VersionPolicyValidator should use ComposerInspector instead of ComposerUtility

Just gave this a start. Not assigning to myself

I think this is blocked on 📌 Updater should use ComposerInspector instead of ComposerUtility Fixed because it need to ask the update which versions it is going update to.

🎉

@Wim Leers and/or @phenaproxima what do you think of my follow-up suggestion?

I had never heard of drupal/core-dev-pinned before today!

You propose \Drupal\package_manager\InstalledPackage to gain a public readonly bool $isDev property — great — but just yesterday that was being worked on in 📌 Updater should use ComposerInspector instead of ComposerUtility Fixed and was removed in favor of ComposerInspector::getRootPackageInfo() returning a devRequires flag for each installed package.

That is what @phenaproxima settled on and you RTBC'd, @tedbow. I was not involved in that pretty significant shift.

So I think the sensible thing to do next is for you to open that follow-up as you envision it, @tedbow 😊

You propose \Drupal\package_manager\InstalledPackage to gain a public readonly bool $isDev property — great — but just yesterday that was being worked on in #3345754: Updater should use ComposerInspector instead of ComposerUtility and was removed in favor of ComposerInspector::getRootPackageInfo() returning a devRequires flag for each installed package.

Not quite.

The property that was originally implemented in that issue, and removed by me, was a change in behavior. Updater needs to see what the dev requirements are, not what the dev packages are. So the implementation was wrong, and was therefore removed.

The follow-up doesn't exist yet — clarifying status.

created follow-up 📌 Remove need for VersionPolicyValidator to know about specific core packages Fixed

Automatically closed - issue fixed for 2 weeks with no activity.