Contrib.social

Update every ComposerValidator-dependent validator to have explicit test coverage that that dependency works

Open on Drupal.org →
Created on 3 March 2023, over 1 year ago
Updated 15 March 2023, over 1 year ago

Problem/Motivation

StagedProjectsValidator has todo to remove a try/catch in 📌 Add a validate() method to ComposerInspector to ensure that Composer is usable Fixed but that issue is already fixed.

Also 📌 Create an API for base requirement validators which run before other validators and stop event propagation if they fail Fixed means we should not get the situation \Drupal\Tests\automatic_updates\Kernel\StatusCheck\StagedProjectsValidatorTest::testEventConsumesExceptionResults creates because we stop the event if Composer set up does not valid

Steps to reproduce

Proposed resolution

Remove \Drupal\Tests\automatic_updates\Kernel\StatusCheck\StagedProjectsValidatorTest::testEventConsumesExceptionResults and the try catch around 

try {
      $active_list = $this->composerInspector->getInstalledPackagesList($this->pathLocator->getProjectRoot());
      $stage_list = $this->composerInspector->getInstalledPackagesList($stage->getStageDirectory());
    }

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

3.0

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024