I have noticed while debugging my code, that after a successful payment my custom written EventSubscriber is not triggering...
I have 3 payment gateways, of which 1 is an offsite, and the 2 others are onsite payment methods.
The issue is with the offsite, because with the other 2, the EventSubscriber gets triggered immediately after I finish the checkout process and click the "Finalize order" button.
I have a hook_preprocess_HOOK in which I have put a dispatch to trigger the commerce_checkout.complete event, but that isn't such a good way of handling things I suppose...
On onsite payments, first is triggered EventSubscriber, and then this preprocess hook, and on offsite, only the hook is triggered and that is when the whole process of putting Card data is applied and the servers returns a successful response.
Closed: works as designed
2.0
Checkout
After debugging, I conclude that I had some custom code that was altering the order, and when that order was saved, it caused this issue.
So I will mark this that it works as designed.