Merge functionality into PWA module and join forces

Created on 2 March 2023, almost 2 years ago

Problem/Motivation

This module doesn't seem to be maintained very actively. Wouldn't it make more sense to join forces on the PWA module and merge functionality?

Thanks!

📌 Task
Status

Active

Version

1.0

Component

Miscellaneous

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • 🇬🇧United Kingdom gMaximus

    Check this out. I've done a lot of development for this module inc flag and rules integration for push notifications.

    https://www.drupal.org/project/advanced_pwa/issues/3293486 🌱 Upgrades to this module to suit community platforms inc Rules and Flag support Needs review

    As you say, this module doesn't seem to be maintained much. I shared those upgrades a long time ago.

    I didn't consider the other module because it didn't seem to cater for push notifications. That's a big thing for my needs.

    What features does the other one have that this does not?

  • 🇩🇪Germany Anybody Porta Westfalica

    Thank you very much for your immediate feedback @gMaximus - don't get me wrong, there we no bad intentions or criticism.

    Still your work hasn't been reviewed or committed, so it seems the Maintainers are inactive?
    Perhaps you may want to open an issue to become Co-Maintainer?

    My request wasn't about missing features, just about having a larger team and active maintainers for one well maintained project instead of two less-maintained projects. In general. That's the case for several Drupal modules.

  • 🇬🇧United Kingdom gMaximus

    I honestly wasn't taking offence :) My question was more curiosity in terms of me missing something.

    I'll do both of your suggestions regarding the merge request and asking to be a maintainer.

    I learned about merge requests and forks after submitting the patches. I do have the upgrades in different patches on my website. So I should be able to make things clearer quite easily.

    More hands and minds are always better in my view.

  • 🇬🇧United Kingdom gMaximus

    Hey @Anybody. I've now created the fork and merge request. I've also added a issue requesting to be a maintainer.

    Look forward to any feedback on the features. Here for any issues. I had to manually apply some of the patches because they didn't seem to apply cleanly.

Production build 0.71.5 2024