- Issue created by @mkalkbrenner
- Status changed to Needs review
over 1 year ago 2:52pm 1 March 2023 - Status changed to Needs work
over 1 year ago 1:36pm 4 March 2023 - π§π·Brazil RenatoG Campinas
#2 is good, but I'd suggest verify the options number and if there is only set we can set the select as "disabled" because don't make sense allow the user to select but we have only 1 option. So I think will improve the User Experience (UX)
- Status changed to Needs review
over 1 year ago 1:37pm 4 March 2023 - π©πͺGermany mkalkbrenner π©πͺ
@jrockowitz What about the patch in #2 in general? Do agree with my issue description?
We use the patch in production now and the editors are happy. - πΊπΈUnited States jrockowitz Brooklyn, NY
The patch from #2 makes sense. I need to download and test the patch locally. Maybe someone else can verify the patch.
- πΊπΈUnited States jrockowitz Brooklyn, NY
It feels like you are making code suggestions just to get a commit credit.
@RenatoG I want to apologize for making this accusation. You have helped with a lot of tickets. It is important that every comment and patch it helps solve the task at hand.
- πΊπΈUnited States jrockowitz Brooklyn, NY
Attached patch incorporate the suggestion from #4 using #access and includes some test coverage.
-
jrockowitz β
authored 2e488f8c on 6.1.x
Issue #3345252 by RenatoG, jrockowitz, mkalkbrenner: Webforms are always...
-
jrockowitz β
authored 2e488f8c on 6.1.x
-
jrockowitz β
authored 2e488f8c on 6.x
Issue #3345252 by RenatoG, jrockowitz, mkalkbrenner: Webforms are always...
-
jrockowitz β
authored 2e488f8c on 6.x
-
jrockowitz β
authored 2e488f8c on 6.2.x
Issue #3345252 by RenatoG, jrockowitz, mkalkbrenner: Webforms are always...
-
jrockowitz β
authored 2e488f8c on 6.2.x
- Status changed to Fixed
about 1 year ago 10:14am 27 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- π§π·Brazil RenatoG Campinas
It feels like you are making code suggestions just to get a commit credit
@jrockowitz you're wrong
- D.O don't have "commit credit"
- Currently is "issue credit"
- So doesn't matter who is the commiter
- And personally speaking I definitely don't need this
Please slow down with your reviews and patches
Sorry, it's a democracy
- It's open-source project
- Everyone are free to make contributions
- If you think that isn't useful, you as maintainer can remove the credits on field "Credit & committing" @see Granting credit to issue contributors β
- But you can't block any user to contribute if he/she wants
- You should respect everyone
- I recommend you to read Drupal Code of Conduct β
- If you don't agree with CoF or project license, feel free to go out and create a private project where you can block people and do everything you want