Optimize Composer calls in FixtureManipulator

📌 Update FixtureManipulator to work with InstalledPackagesList, real composer show command Fixed needs to land before this can be actionable.

📌 Update FixtureManipulator to work with InstalledPackagesList, real composer show command Fixed landed! And since this could help address #3338789-28: Random failure: "PHP temp directory (/tmp) does not exist or is not writable to Composer." → , pulling into the sprint…

Unfortunately, the test timings are not consistent and it seems that grouping require calls don't help much.

The conclusion.

1. So, as a last resort i tried to handle all addPackage() calls as group calls but since the test times are pretty much similar to the 3.0.x baseline it seems to make little to no difference to the performance so complicating it doesn't make sense.
   

      unit test - same
      MR vs 3.0.x
      kernel 4.23 vs 4.21
      build 8.14 vs 8.11
      functional 2.42 vs 2.43
   

2. But i also think that we could simplify addPackage() with same structure that i used to make group calls possible.

@omkar.podey thanks for working on this. Yes, I don't think with the minimal performance this something we should probably spend anymore time on.

I think we can leave it open from now but set the priority to minor removing the sprint. If someone really wants to tackle this they could try to figure how to make it better they are willing to try.

but I think to if we were to commit a fix for this it could not make the class that much harder to understand. So I am doubtful that can be done.

Huh, it feels like comments of mine have been deleted from this issue? 😳

I'd swear we've had a conversation both via audio and here with at least @tedbow about closing this instead of leaving it open like #14 says since if it's not worth doing now, it never will be.

Also, the April 6 comment at #14 was marked as "new" for me here, which seems impossible? 🤪

Either way, assigning to @tedbow for hopefully marking this as I suggested in #16.

@Wim Leers I think we might have chatted in slack