- Issue created by @Atropoides
- @atropoides opened merge request.
- Status changed to Needs review
over 1 year ago 12:24pm 1 March 2023 - @atropoides opened merge request.
- Status changed to Needs work
over 1 year ago 4:53pm 1 March 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Very nice implementation, only left one comment inline in code with a minor suggested change.
- Status changed to Needs review
over 1 year ago 9:22am 2 March 2023 - 🇩🇪Germany Atropoides Hamburg
I hope I have understood it correctly and implemented your feedback correctly.
- Status changed to RTBC
over 1 year ago 10:44am 2 March 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Yes, this is great. I only replaced the second if-statement with an elseif and moved the comments inside the if-statements.
Thanks a lot @Atropoides for this contribution.
-
jurgenhaas →
committed e5d47353 on 1.2.x authored by
Atropoides →
Issue #3345206 by Atropoides, jurgenhaas: Make token pass the validation...
-
jurgenhaas →
committed e5d47353 on 1.2.x authored by
Atropoides →
- Status changed to Fixed
over 1 year ago 10:47am 2 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.