Add extra classes to results form

Created on 1 March 2023, over 1 year ago
Updated 2 March 2023, over 1 year ago

Problem/Motivation

Add extra classes to results form like media library in core has.

Proposed resolution

Add the extra classes

Remaining tasks

Review

Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇧🇪Belgium Mschudders

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Mschudders
  • @mschudders opened merge request.
  • 🇳🇱Netherlands seanB Netherlands

    These js- prefixed classes should not be necessary for our custom search form. The related JavaScript code from the media library doesn't do anything we need if I'm not mistaken. Could you explain why these classes should be added?

  • 🇧🇪Belgium Mschudders

    Hello,

    They are indeed not needed. But I just wanted to more aligned with the core "media_library" module were they are also added. I noticed they weren't there since our theming didn't work here on the search form. (They are based on the js- classes) But it is indeed a trivial "problem" let's say. Theming can be altered easily

    I could agree on closing or committing.

Production build 0.71.5 2024