- Issue created by @Mschudders
- @mschudders opened merge request.
- 🇳🇱Netherlands seanB Netherlands
I can imagine "Add by keyword" is not perfect, but I think "Keyword" might be more confusing. The media library also contains an exposed form below the add form, so that could mean there are multiple fields with a label named "Keyword" that accomplish different thing.
The exposed form searches for media items that already have been added, while the keyword field in the add form is meant to add new external media by first searching the external media via a keyword.
Maybe a better title would be: "Import by keyword"?
We could also add and extra description below the field: "Search [provider] by keyword for items to import."? - 🇧🇪Belgium Mschudders
What would you think about adding an extra button next to "Add selected", "Search for X" .
X is the name of Media bundle.The "Add form" is removed from the Media bundle tab and only accessible via our new button "Search for X".
This will also eliminate the problem with double keyword label.
- 🇧🇪Belgium Mschudders
I personally do not think that "Add or import" is the correct action for the label for the textfield.
Because this action happens only if you find an image that you like.
You need to search for it first - 🇧🇪Belgium Mschudders
I do not know if this is the way to go with my latest code.
The current drawback (which was already there in the beginning) is that the form is validated and thus the "Keyword" throws an error: "Hey fill me in ....
We can remove the #required ofcourse but does that make sense.
2/
I personally do think that the button label "Import from X" (Import from Pexels, for example) does not add any value for a website user, or is irrelevant.Just "import form external media", or "Import" would be enough I think.
Kind regards,
- 🇳🇱Netherlands seanB Netherlands
The attached patch implements how I envisioned it. Can you check if this is roughly what you meant?