- Issue created by @Mschudders
- @mschudders opened merge request.
- 🇳🇱Netherlands seanB Netherlands
Thanks for the issue. This makes sense to add! The current implementation will probably break existing plugins though. Not sure yet how to get this done in a backwards compatible way. One thing we could do is add a service to wrap the current plugin calls:
$provider->search($keyword, $this->pagerManager->findPage());
$photo = $provider->load($external_id);
This new service could then implement the caching so the plugins themselves don't need to worry about that. What do you think about that?
- 🇧🇪Belgium Mschudders
Well we could make a Major release?
Nonetheless this way a Plugin could still choose to not have caching. For example, for specific external media libraries you maybe don't want caching?
If a major release isn't possible we could look into it further.
- 🇧🇪Belgium Mschudders
another solution would be to have 2 different interfaces.
Any other change won't have any effect from our point of view.
since extending classes still call parent::load for example, it doesn't change - Status changed to Needs work
over 1 year ago 12:06pm 22 April 2023 - 🇧🇪Belgium Mschudders
I've already worked a intermediary service for caching.
Not yet tested though. I suppose this is the way you want it?
- 🇧🇪Belgium Mschudders
tested and fixed some issues.
Caching is working properly.
Todo check diff of main branch
- Status changed to Needs review
over 1 year ago 6:06am 24 April 2023 -
seanB →
committed fa8622d4 on 1.0.x authored by
Mschudders →
Issue #3345140: Implement caching strategy for the API calls.
-
seanB →
committed fa8622d4 on 1.0.x authored by
Mschudders →
- Status changed to Fixed
about 1 year ago 4:35am 19 July 2023 - 🇳🇱Netherlands seanB Netherlands
Nice work! Added some changes before merging to use a single cache backend and renamed the cache wrapper services, but overall it worked perfectly. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.