- Issue created by @Atropoides
- @atropoides opened merge request.
- @atropoides opened merge request.
- Status changed to Needs review
over 1 year ago 2:52pm 28 February 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Thanks a lot @Atropoides for your contribution, this is much appreciated.
Your MR315 looks perfect for the status piece of this issue. And I would give it RTBC.
Question remains what to do with the token usage in email fields. My suggestion: let's move this into a separate issue, rename this one to be on topic for the status field.
The approach for the token in email fields should then be a third option: like with number fields, where we had the same issue, we can recognize a token value when saving a model and pre-emptively replace the token with a fake email address before validation and reset the value afterwards. That gives us most of both worlds.
What do you think?
- 🇩🇪Germany Atropoides Hamburg
Sounds reasonable. Then I would remove the
'#element_validate' => []
so this MR is only for the status.
After that I can open a new issue and checkout your solution for the number fields. - Status changed to RTBC
over 1 year ago 4:45pm 1 March 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Nice work, thanks a lot @Atropoides for your first and really helpful contribution.
Setting this to RTBC, only had to bring back a comma that was lost when removing the validator.
-
jurgenhaas →
committed 068e77b8 on 1.2.x authored by
Atropoides →
Issue #3344964 by Atropoides, jurgenhaas: Extend new user action...
-
jurgenhaas →
committed 068e77b8 on 1.2.x authored by
Atropoides →
- Status changed to Fixed
over 1 year ago 4:47pm 1 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.