- Issue created by @Rohit Rana
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:06am 28 February 2023 - 🇮🇳India nayana_mvr
Verified the patch #2 on Drupal version 10.1.x and Type Style version 8.x-1.x.
Command used isVendor/bin/phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml modules/contrib/type_stylePatch applied cleanly but there are few more errors.
FILE: .../contrib/type_style/type_style.module ------------------------------------------------------------------------------------------------ FOUND 5 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------ 49 | ERROR | [ ] Type hint "array" missing for &$form 49 | ERROR | [ ] Type hint "array" missing for $settings 62 | ERROR | [x] Use null coalesce operator instead of ternary operator. 68 | ERROR | [x] Use null coalesce operator instead of ternary operator. 126 | ERROR | [x] Use null coalesce operator instead of ternary operator. ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: .../contrib/type_style/modules/type_style_moderation/type_style_moderation.install ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 4 | ERROR | [x] Doc comment short description must be on the first line ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: .../contrib/type_style/modules/type_style_moderation/type_style_moderation.info.yml ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------------------------- FILE: .../contrib/type_style/modules/type_style_moderation/type_style_moderation.module ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 4 | ERROR | [x] Doc comment short description must be on the first line 30 | ERROR | [x] Use null coalesce operator instead of ternary operator. 61 | ERROR | [x] Use null coalesce operator instead of ternary operator. 99 | ERROR | [x] Use null coalesce operator instead of ternary operator. 131 | ERROR | [x] Use null coalesce operator instead of ternary operator. ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- - @nayana_mvr opened merge request.
- 🇮🇳India nayana_mvr
I just tried to fix the remaining issues and created the MR!1 with all the changes. Please review.
Thanks.