- Issue created by @JCL324
- Assigned to elber
- Issue was unassigned.
- Status changed to Postponed
almost 2 years ago 12:51pm 28 February 2023 - π§π·Brazil elber Brazil
Hi this needs to be postponed because when I try to acess the config form using the route
/admin/config/geoblock
I have this error: "Error: Class "League\ISO3166\ISO3166" not found in Drupal\geoblock\Form\SettingsForm->getCountryCodeOptions() (line 163 of modules/contrib/geoblock/src/Form/SettingsForm.php)."I wil open another issue to fix the error.
- Status changed to Closed: won't fix
almost 2 years ago 5:01pm 28 February 2023 - πΊπΈUnited States clayfreeman Paragould, AR
This project uses a very strict interpretation of Drupal's backward compatibility policy β which prevents us from leveraging Drupal's administration menu out of the box. If you wish to add an item to Drupal's administration menu, you can still do so manually by navigating to Structure > Menus > Administration > Add link and using the following path:
/admin/config/geoblock
. - πΊπΈUnited States JCL324 Portland, OR
@clayfreeman, please do tell me how this violates the policy. Contrib modules add links all the time! It could easily go under admin/config/development or admin/config/system.
- πΊπΈUnited States clayfreeman Paragould, AR
Defining a menu link in the administration menu would require this module to establish a potentially disruptive, implicit dependency on Drupal's current menu structure -- in this case, the plugin ID of a given parent menu item provided by Drupal core. While the backward compatibility policy does state that "plugin IDs [...] can be relied upon," I've chosen to avoid this implicit dependency.
This module instead leverages the
configure
key in its*.info.yml
, which adds a "Configure" link to the module's description on the "Extend" page. Should Drupal choose to forgo this concept in the future, there is no potentially disruptive dependency relationship to worry about.Reliability is a primary priority for this module. I may be paranoid in making this decision, but given that unintended side effects could result in an inaccessible site, I want to reduce the incidence of these types of scenarios as much as possible.
All that being said, end users who need a menu link can still add one manually.