ActivityPub Settings appears unable to save due to hidden required field makes "Older than" for "Remove old activities"

Oh, funky :)

The default value should be 0 by default - that's at least in settings.yml, and activitypub_update_8017() should have added it, not sure what or why goes wrong here.

Also, looking at the #min value of that field, it's set to 0, which is probably a bad idea too.

Patch attached which does this:

- set #min to 1
- remove the #required key in the form element
- add #required via states
- add validate function in case #states fails for some reason.
- switches the default in settings.yml to 1 (not going to write an update function for this one)

The last submitted patch, 4: 3344773-4.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Ugh, seconds after I tested the patch, I noticed that in case the default value would still be 0, the form wouldn't submit either. Annoying, maybe I'll just keep that at #min => 0; in that case the PHP validation message will kick in as well. Just need a better message at that point than the one I've put in the patch.

Also, the tests fails because remove activities was now 1 by default :)
(great I have tests for that, didn't even remember that)

Back to 0 it is, suggestions welcome for a better error message.

Automatically closed - issue fixed for 2 weeks with no activity.