Contrib.social

Do not disable package_manager.validator.composer in tests

Open on Drupal.org →
Created on 27 February 2023, about 2 years ago

Problem/Motivation

AutomaticUpdatesFunctionalTestBase we have 

    // Disable the Composer executable validator, since it may cause the tests
    // to fail if a supported version of Composer is unavailable to the web
    // server. This should be okay in most situations because, apart from the
    // validator, only Composer Stager needs run Composer, and
    // package_manager_bypass is disabling those operations.
    // @todo https://www.drupal.org/project/automatic_updates/issues/3320755.
    'package_manager.validator.composer',

This is not true anymore because ComposerInspector uses Composer

Also we forgot to remove the todo in #3320755: Remove unnecessarily disabled automatic_updates.composer_executable_validator → which was for a different validator here.

Steps to reproduce

Proposed resolution

Try remove here and see if tests pass

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024