- Issue created by @giordy
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
This is actually a major D10 Compatibility issue.
The module is not installable because of a dependency on ckeditor (which is removed from core and replaced by ckeditor5)
Because of that the "CKEditorPluginBase" can't be found because it's moved into a different module. It's actually a totally different implementation for D10/Ckeditor5 - First commit to issue fork.
- 🇺🇦Ukraine dbuzinov
You can install the CKEditor5 version of the module using this configuration of the composer.json file:
{
"require": {
"drupal/ckeditor_wiris": "dev-3344505-ckeditor5",
},
"repositories": [
{
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/ckeditor_wiris"
]
},
{
"type": "git",
"url": "https://git.drupalcode.org/issue/ckeditor_wiris-3344505"
}
],
} - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Totally missed the MR, sorry for that.
Just tried it out and it doesn't seem to work. I can add the items to the editor, but when trying to use them I get this error.
editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1 Uncaught TypeError: language.toLowerCase is not a function at com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel.normalizeLanguage (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:47589) at com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel.setParam (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:49468) at com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel.setParams (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:54900) at new com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:31475) at com.wiris.editor.EditorModel.getNewInstanceFromJSON (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:35219) at com.wiris.editor.EditorModel.getNewInstanceWithParams (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:33311) at new com.wiris.js.JsEditor.vm2.com.wiris.js.JsEditor (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:588185) at com.wiris.js.JsEditor.newInstance (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:589814) at y.insertEditor (MathType.js?s90qkq:1:154045)
- Status changed to Needs work
10 months ago 9:10pm 17 February 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
BramDriesen → changed the visibility of the branch 3344505-ckeditor-5-buttons to hidden.
- Status changed to Needs review
10 months ago 5:05pm 8 March 2024 - 🇺🇦Ukraine dbuzinov
Np, MR was updated. Looks like there were some updates on language detection on wiris side.
Please review and test.
-
BramDriesen →
committed b1b54259 on 3.0.x authored by
dbuzinov →
Issue #3344505 by BramDriesen, dbuzinov: CKEditor5 compatibility
-
BramDriesen →
committed b1b54259 on 3.0.x authored by
dbuzinov →
- Status changed to Fixed
9 months ago 11:25am 21 March 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Not sure how I ended up on the other MR :) this is merged now!
Will do one follow up ticket to update npm packages and will then tag a release. Thanks everyone!
Automatically closed - issue fixed for 2 weeks with no activity.