CKEditor5 compatibility

Created on 26 February 2023, almost 2 years ago
Updated 4 April 2024, 9 months ago

Problem/Motivation

CKEditor buttons not showing

This beautiful form is really important to me.
With CKEditor 4 it works but I have this problem:
https://www.drupal.org/project/ckeditor_wiris/issues/3344413 🐛 Toolbar not fully visible Active

With CKEditor 5 the two buttons are not visible.

Solutions?

Thanks

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇮🇹Italy giordy

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @giordy
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    This is actually a major D10 Compatibility issue.

    The module is not installable because of a dependency on ckeditor (which is removed from core and replaced by ckeditor5)
    Because of that the "CKEditorPluginBase" can't be found because it's moved into a different module. It's actually a totally different implementation for D10/Ckeditor5

  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    This needs a branch on it's own 😅

  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪
  • Merge request !5Issue #3344505: CKEditor5 compatibility → (Closed) created by dbuzinov
  • First commit to issue fork.
  • Merge request !1Resolve #3344505 "Ckeditor5" → (Merged) created by dbuzinov
  • Merge request !6Issue #3344505: CKEditor5 compatibility → (Merged) created by dbuzinov
  • 🇺🇦Ukraine dbuzinov

    You can install the CKEditor5 version of the module using this configuration of the composer.json file:

    {
    "require": {
    "drupal/ckeditor_wiris": "dev-3344505-ckeditor5",
    },
    "repositories": [
    {
    "type": "composer",
    "url": "https://packages.drupal.org/8",
    "exclude": [
    "drupal/ckeditor_wiris"
    ]
    },
    {
    "type": "git",
    "url": "https://git.drupalcode.org/issue/ckeditor_wiris-3344505"
    }
    ],
    }

  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    Totally missed the MR, sorry for that.

    Just tried it out and it doesn't seem to work. I can add the items to the editor, but when trying to use them I get this error.

    editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1 Uncaught TypeError: language.toLowerCase is not a function
        at com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel.normalizeLanguage (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:47589)
        at com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel.setParam (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:49468)
        at com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel.setParams (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:54900)
        at new com.wiris.editor.EditorModel.vm2.com.wiris.editor.EditorModel (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:31475)
        at com.wiris.editor.EditorModel.getNewInstanceFromJSON (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:35219)
        at com.wiris.editor.EditorModel.getNewInstanceWithParams (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:33311)
        at new com.wiris.js.JsEditor.vm2.com.wiris.js.JsEditor (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:588185)
        at com.wiris.js.JsEditor.newInstance (editor?lang=[object%20Object]&stats-editor=CKEditor5&stats-mode=xml&stats-version=8.8.2.1481:1:589814)
        at y.insertEditor (MathType.js?s90qkq:1:154045)
    
  • Status changed to Needs work 10 months ago
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    BramDriesen changed the visibility of the branch 3344505-ckeditor-5-buttons to hidden.

  • Status changed to Needs review 10 months ago
  • 🇺🇦Ukraine dbuzinov

    Np, MR was updated. Looks like there were some updates on language detection on wiris side.

    Please review and test.

  • Pipeline finished with Success
    9 months ago
    Total: 837s
    #124865
  • Pipeline finished with Canceled
    9 months ago
    Total: 189s
    #124894
  • Pipeline finished with Success
    9 months ago
    #124901
  • Pipeline finished with Success
    9 months ago
    Total: 632s
    #124945
  • Pipeline finished with Success
    9 months ago
    Total: 585s
    #124960
  • Pipeline finished with Success
    9 months ago
    Total: 512s
    #124969
  • Pipeline finished with Success
    9 months ago
    Total: 1297s
    #124985
  • Pipeline finished with Success
    9 months ago
    Total: 960s
    #125004
  • Pipeline finished with Success
    9 months ago
    Total: 440s
    #125009
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪
  • Pipeline finished with Success
    9 months ago
    Total: 875s
    #125017
  • Pipeline finished with Success
    9 months ago
    Total: 147s
    #125028
  • Pipeline finished with Success
    9 months ago
    Total: 149s
    #125069
  • Status changed to Fixed 9 months ago
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    Not sure how I ended up on the other MR :) this is merged now!

    Will do one follow up ticket to update npm packages and will then tag a release. Thanks everyone!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024