- Issue created by @jungle
- Status changed to Needs review
almost 2 years ago 3:11pm 25 February 2023 - First commit to issue fork.
- @ressa opened merge request.
- 🇩🇰Denmark ressa Copenhagen
Thanks for catching the missing indentations @jungle. I do prefer to use
1.
's in numbered lists, since it makes it simpler to maintain longer lists, so kind of a "best practice" in my opinion. It is also used in the README.md template → .I created a new branch for easier previewing, and added a Merge Request, please review.
- 🇨🇳China jungle Chongqing, China
Hi, @ressa I would suggest to use `-`s instead of `1`s.
While users may read plain markdown, using '1's in the text may be confusing and inappropriate. The documentation that mentions this usage could be considered a false positive.
- 🇩🇰Denmark ressa Copenhagen
Hi @jungle, maybe we should keep it an ordered list, since these are steps, to be done in that order? But if you prefer
1.
2.
, etc. let's go for that :)PS. Two more examples, where they prefer
1.
's: - 🇨🇳China jungle Chongqing, China
@ressa, I appreciate your examples and find them convincing. However, to avoid any confusion, would it be possible to add a note with a link to the documentation to indicate that is a best practice, another example in examples, right?
- 🇩🇰Denmark ressa Copenhagen
Thanks for taking the time to check out the Gitlab Markdown style guide @jungle.
Do you mean adding a new line to README.md template → , something like this?
- [...]
- Bulleted lists denoted by dashes (
-
) - Ordered lists using
1.
's (for example, see Configuration → ) - Nested lists indented with 4 spaces
- [...]
- 🇨🇳China jungle Chongqing, China
+++ b/README.md @@ -48,14 +48,14 @@ about how to use Composer with Drupal on
@ressa, I meant to append a note at the button of the README.md if you agree, e.g.:
Note: In this file, `1.`'s are used for the ordered list, which is a "best practice" (see [README.md template
]( https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → ))
- 🇩🇰Denmark ressa Copenhagen
@jungle: That's a great idea, since many don't know it's actually valid Markdown. I just now added a line in the README.md template → about ordered lists.
- Status changed to Needs work
almost 2 years ago 12:43pm 26 February 2023 - 🇨🇳China jungle Chongqing, China
@ressa, expecting your option on 🌱 [Policy] Add README.md to each submodule with optional getting translated Active , thanks!
- Status changed to Needs review
almost 2 years ago 1:48pm 26 February 2023 - 🇩🇰Denmark ressa Copenhagen
Great idea @jungle! I added a comment in that issue, and updated the MR here, with your suggestion.
- Status changed to RTBC
almost 2 years ago 3:06am 28 February 2023 - 🇨🇳China jungle Chongqing, China
FYI, Wrapped each line in less than 80 chars, and changed
reenable
tore-enable
- Status changed to Fixed
almost 2 years ago 3:07am 28 February 2023 - 🇩🇰Denmark ressa Copenhagen
You're welcome, it looks great.
And thank you for all your great work with the Examples module!
Automatically closed - issue fixed for 2 weeks with no activity.