Contrib.social

Fixed the inconsistence between "Fixed width" and "Auto width" at the same time

Open on Drupal.org →
Created on 25 February 2023, over 1 year ago

Problem/Motivation

Currently there is a checkbox field called "Fixed width" that the editors can choose an fixed width for the carrousel and it works fine. But there is another field (checkbox) called "Auto width" that the user can mark to apply automatically. If the issue put a value in the "fixed width" and keep the "Auto width" unchecked it works fine. But if the user put a value in the "fixed width" mark the "Auto width" the fixed value will not be applied.
It makes sense because if was selected to use "Auto width" doesn't makes sense put a fixed width. But I think we can put a #form states when the user mark "auto width" set the "fixed width" as "disabled"

Steps to reproduce

Put a value in the fixed width and after that mark the auto width, look in the FE, the fixed isn't considered

Proposed resolution

Update the order in the form, to "Auto width" appear first and "Fixed width" appear after.
If the user choose "Auto width" we can disable the "Fixed width" automatically using #states from Form API

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Fixed

Version

1.4

Component

Code

Created by

🇧🇷Brazil RenatoG Campinas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024