- Issue created by @swentel
- π§πͺBelgium swentel
Note: I'll check this weekend if I can find some time to set this up. I've done this a few times now already with AP and IndieWeb, so I can copy paste quickly :)
Side note: I'm working on a very experimental module to send the notes which I create on my site to the Nostr network, with some luck I'll be able to create a small PHP library also that is able to convert keys from bech32 to hex or vice versa so both projects can benefit from that :)
- π³π±Netherlands sebastian hagens Breda, Netherlands
Sebastian Hagens β made their first commit to this issueβs fork.
- Assigned to sebastian hagens
- Status changed to Needs work
over 1 year ago 8:37am 28 February 2023 - π³π±Netherlands sebastian hagens Breda, Netherlands
I completely agree with you on that. This first development release was very lean & mean and on one server I was already having issues with permissions for writing the file. For me it's the first contrib module for Drupal I submitted, so I'm open to any feedback to learn!
I will be really honored with your feedback, I know your work from the fediverse space and your Drupal history goes way back further in time than mine.I just pushed new code where I started to refactor the whole.
For the multiple user support, I will create a new ticket to separate things into smaller pieces to work on.
I've already included your package `swentel/nostr-php` but it's not used yet in the code for converting the pubkey.
Is there a way you now can review/comment the code in the MR (wip/draft) I've opened in the Gitlab space?
- @sebastian-hagens opened merge request.
-
Sebastian Hagens β
committed d97ecfb2 on 1.0.x
Issue #3344419: Use a controller instead of writing to the .well-known...
-
Sebastian Hagens β
committed d97ecfb2 on 1.0.x
- Status changed to Needs review
over 1 year ago 9:53pm 10 March 2023 - π§πͺBelgium swentel
Looks pretty solid!
Small detail: you inject the database in the controller, but not AddNostrKeyForm
Other than that, love the alter already, that's a good way to hold off on future feature requests :) - π³π±Netherlands sebastian hagens Breda, Netherlands
Thanks for point that out! I'm learning small new things here along the way :) Pushed some changes again.
The alter was inspired by your nodeinfo module ;)
- @sebastian-hagens opened merge request.
- Status changed to Fixed
over 1 year ago 7:51am 15 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.